This repository was archived by the owner on Oct 25, 2021. It is now read-only.
Open
Conversation
…zura # Conflicts: # src/main/java/homework_1/Main.java # src/main/java/lesson_2/Main.java
NikolaevArtem
added
bug
NikolaevArtem
added
HW_1
Owner
|
Good! All tests pass, the apps work as expected. There's small comment to fix |
pepya4ka
reviewed
Aug 22, 2021
Comment on lines
+66
to
+67
| ClassLoader classLoader = getClass().getClassLoader(); | ||
| return new File(Objects.requireNonNull(classLoader.getResource(fileName)).getFile()); |
Collaborator
There was a problem hiding this comment.
Suggested change
| ClassLoader classLoader = getClass().getClassLoader(); | |
| return new File(Objects.requireNonNull(classLoader.getResource(fileName)).getFile()); | |
| return new File(pathToResources + fileName); |
|
|
||
| public class Main { | ||
| public static void main(String[] args) { | ||
| new GameLauncher().launch(); |
Owner
There was a problem hiding this comment.
It's pretty uncomfortable to play... especially to put ships. Also, what rules did you use? I strongly remember there should be 1 4-cells ship and 4 1-cell ships...
Owner
There was a problem hiding this comment.
CARRIER(5),
BATTLESHIP(4),
CRUISER(3),
SUBMARINE(3),
DESTROYER(2);
From your code
Collaborator
Author
There was a problem hiding this comment.
Rules: https://www.hasbro.com/common/instruct/Battleship.PDF
Also, we were free to choose ui, as I remember
Owner
There was a problem hiding this comment.
In case of wrong input app shuts down...
Hitting the same cell is allowed
Owner
There was a problem hiding this comment.
Interface is nice though, but the app is buggy. I'm sorry I can't accept that
NikolaevArtem
added
bug
Comment on lines
+4
to
+8
| public static void main(String[] args) { | ||
| new CustomFileReader().run1(); | ||
| new CustomFileReader().run2(); | ||
| new CustomFileReader().run3(); | ||
| } |
| public class Main { | ||
|
|
||
| public static void main(String[] args) { | ||
| new PowerOfNumber().run(); |
NikolaevArtem
added
HW_5
HW_6
HW_7
and removed
readyForReview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.